Add support for setting security attributes on Http.Sys RequestQueue #61325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-networking
BrennanConroy
commented
Apr 4, 2025
BrennanConroy
force-pushed
the
brecon/requestqueuesecurity
branch
from
10ebaa7 to
cabcc2f
Compare
BrennanConroy
requested review from
JamesNK,
halter73 and
mgravell
as code owners
|
|
||
| _disposed = true; | ||
|
|
||
| PInvoke.HttpCloseRequestQueue(Handle); |
There was a problem hiding this comment.
Seems like a reasonable change but unrelated to this PR. Drive-by bug fix or is it related somehow?
There was a problem hiding this comment.
Drive-by, was just reading the docs for HttpCreateRequestQueue to make sure I was doing the correct thing with the security attribute and noticed it said you should close the queue handle with HttpCloseRequestQueue.
dotnet-policy-service
bot
added
the
pending-ci-rerun
captainsafia
approved these changes
Apr 28, 2025
| HttpCancelHttpRequest | ||
| HttpCloseServerSession | ||
| HttpCloseUrlGroup | ||
| HttpCloseRequestQueue |
There was a problem hiding this comment.
It's how the cswin32 source generator decides what methods to create PInvokes for
https://microsoft.github.io/CsWin32/docs/getting-started.html
BrennanConroy
removed
the
pending-ci-rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61084